From 6c17e301fbad8ec917cb5457884c3c3f74dffc6d Mon Sep 17 00:00:00 2001 From: CosmicHazel <7584038+CosmicHazel@users.noreply.github.com> Date: Sun, 15 Jun 2025 01:42:02 -0400 Subject: [PATCH] Fix typos and add extended pattern matching - Fix typo in build.sh: 'commmand' -> 'command' - Fix incorrect script name in README: 'recc_encode_install.sh' -> 'recc_encode.sh' - Add shopt -s extglob to enable extended pattern matching in bash scripts --- README.md | 2 +- scripts/build.sh | 5 ++++- scripts/recc_encode.sh | 3 +++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 4abe1c9..ba12cb5 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ With the scripts, you can: 1. Install required dependencies using `./scripts/install_deps.sh` 2. Build and install ffmpeg from source using `./scripts/build.sh` -3. Install an encoding script using `./scripts/recc_encode_install.sh -I` +3. Install an encoding script using `./scripts/recc_encode.sh -I` 4. Install a film-grain estimation script using `./scripts/estimate_fg.sh -I` 5. Benchmark the different encoders using `./scripts/benchmark.sh` diff --git a/scripts/build.sh b/scripts/build.sh index 9a00f4f..a498b1e 100755 --- a/scripts/build.sh +++ b/scripts/build.sh @@ -1,5 +1,8 @@ #!/usr/bin/env bash +# Enable extended pattern matching for ?() and +() operators +shopt -s extglob + usage() { echo "./scripts/build.sh [options]" echo -e "\th:\tdisplay this help output" @@ -201,7 +204,7 @@ then fi # compilation job count -if commmand -v nproc 2> /dev/null ; then +if command -v nproc 2> /dev/null ; then THREADS="$(nproc)" fi diff --git a/scripts/recc_encode.sh b/scripts/recc_encode.sh index 63cd3b7..7118110 100755 --- a/scripts/recc_encode.sh +++ b/scripts/recc_encode.sh @@ -1,5 +1,8 @@ #!/usr/bin/env bash +# Enable extended pattern matching for ?() and +() operators +shopt -s extglob + # this is simply my recommended encoding method. # do not take this as a holy grail.